Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some functions that were only used by Miri #85412

Merged
merged 1 commit into from
May 17, 2021

Conversation

RalfJung
Copy link
Member

and Miri does not need them any more with rust-lang/miri#1805.

r? @oli-obk

@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2021
@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2021

If you wait for the miri PR and do a miriup in this pr, you can avoid toolstate breakage. Whatever you prefer, r=me

@RalfJung
Copy link
Member Author

Miri toolstate is already red.^^

@oli-obk
Copy link
Contributor

oli-obk commented May 17, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 17, 2021

📌 Commit cb5533c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2021
RalfJung added a commit to RalfJung/rust that referenced this pull request May 17, 2021
remove some functions that were only used by Miri

and Miri does not need them any more with rust-lang/miri#1805.

r? `@oli-obk`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85087 (`eval_fn_call`: check the ABI of `body.source`)
 - rust-lang#85302 (Expand WASI abbreviation in docs)
 - rust-lang#85355 (More tests for issue-85255)
 - rust-lang#85367 (Fix invalid input:disabled CSS selector)
 - rust-lang#85374 (mark internal inplace_iteration traits as hidden)
 - rust-lang#85408 (remove size field from Allocation)
 - rust-lang#85409 (Simplify `cfg(any(unix, target_os="redox"))` in example to just `cfg(unix)`)
 - rust-lang#85412 (remove some functions that were only used by Miri)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a28be5c into rust-lang:master May 17, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 17, 2021
@RalfJung RalfJung deleted the c_str branch May 18, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants